Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

move config.h from mros2/embeddedRTPS/include/rtps/ #4

Merged
merged 4 commits into from
Feb 23, 2022
Merged

move config.h from mros2/embeddedRTPS/include/rtps/ #4

merged 4 commits into from
Feb 23, 2022

Conversation

takasehideki
Copy link
Member

@takasehideki takasehideki commented Feb 22, 2022 •
edited
Loading

This file can set the configuration of RTPS.
See also:
mROS-base/embeddedRTPS#8 (comment)

@smoriemb How do you think this modification? If you like it, please merge this PR.
MAX_NUM_PARTICIPANTS is set to 1 according to your PR mROS-base/embeddedRTPS#8

@takasehideki
move config.h from mros2/embeddedRTPS/include/rtps/
51ad430 
This file can set the configuration of RTPS.
See also:
mROS-base/embeddedRTPS#8 (comment)
takasehideki added a commit to mROS-base/embeddedRTPS that referenced this pull request Feb 22, 2022
@takasehideki
move include/rtps/config.h to each target repository
c3acc89 
See also:
#8 (comment)
mROS-base/mros2-mbed#4
@takasehideki takasehideki mentioned this pull request Feb 22, 2022
Merged
@takasehideki
Copy link
Member Author

I added a tiny fix to README in this PR c14ed1a

@takasehideki
Copy link
Member Author

takasehideki commented Feb 23, 2022 •
edited
Loading

I created mros2 v0.2.3.1, which only contains the update about mROS-base/embeddedRTPS#9 to mros2 v0.2.3, and follow it into mros2.lib. bef6a1f

Since significant changes have been done to mros2 v0.3.0 (to support custom MsgType), we could not use this yet in this repository. I will work on following v0.3.0 in the next task, but I think it is more convenient for you to use v0.2.3.1 to verify the validity of this PR.

@smoriemb
Copy link
Contributor

Thanks for your consideration.

Your solution sounds more comprehensive than mine considering just only the Mbed case.
I've confirmed your PR works well with my 429ZI and Arch Max, and updated README.md to support the Arch Max board.

@takasehideki
Copy link
Member Author

@smoriemb thanks for confirmation on your boards! I will merge it.

@takasehideki takasehideki merged commit 21dec69 into main Feb 23, 2022
@takasehideki takasehideki deleted the mv_rtps_config branch February 23, 2022 05:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@smoriemb smoriemb Awaiting requested review from smoriemb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@takasehideki @smoriemb